Repository navigation
Conversation
The interior zoom-out hook keyed its native-radius capture and restore by the OrbitFrameProvider instance. That provider is recreated across scene/section transitions, but the Constraint.FloatData radius object it drives persists and is shared with the exterior station camera. When a widened provider was torn down before it next ticked outside the interior, the widened radius was inherited by a freshly created exterior provider the hook had never captured, so the restore branch (find(provider) miss) never fired and the exterior stayed pinned at scale*native: zoomed out and un-zoomable. Key the capture and restore by the radius object instead of the provider, so any provider that later presents that radius restores it to native on its first exterior frame (and a stuck state self-heals). The map key stays compare-only and the stored value is plain floats, so no stale-object access is introduced. Follow-up to STFC-Mod#332.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #332. Rarely, the station exterior view could get stuck zoomed out at
interior_zoom_scalewith no zoom control normally available to recover it from exterior view. It turns out the provider gets recreated across transitions while the radius object it drives persists, so we key on the radius instead.