Skip to content

Recover anomaly timer owners across registered HUD canvases #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Guffawaffle wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Recover anomaly timer owners across registered HUD canvases #350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
829d3ca
Resolve anomaly HUD owners through their registered canvases
Guffawaffle Oct 25, 2026
04b2e4e
Retain inactive owner recovery and cache whole displayed seconds
Guffawaffle Oct 25, 2026
6349618
Invoke the non-generic anomaly owner component overload
Guffawaffle Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 74 additions & 29 deletions mods/src/patches/parts/galactic_anomaly_timer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,20 @@ bool TryInvoke(const MethodInfo* method, void* target, void** args, Il2CppObject
}

// Unity has Type/string and generic overloads with the same argument count.
const MethodInfo* TypeMethod(Il2CppClass* cls, const char* name)
const MethodInfo* TypeMethod(Il2CppClass* cls, const char* name, int argumentCount = 1)
{
// The shared filtered lookup cannot inspect is_generic and only searches
// one class. Keep the overload check here so a generic overload cannot win.
void* iter = nullptr;
while (cls) {
while (auto* method = il2cpp_class_get_methods(cls, &iter)) {
if (method->is_generic || std::strcmp(method->name, name) || method->parameters_count != 1)
if (method->is_generic || std::strcmp(method->name, name) || method->parameters_count != argumentCount)
continue;
if (argumentCount == 2) {
auto* second = il2cpp_method_get_param(method, 1);
if (!second || il2cpp_type_is_byref(second) || il2cpp_type_get_type(second) != IL2CPP_TYPE_BOOLEAN)
continue;
}
auto* param = il2cpp_class_from_type(il2cpp_method_get_param(method, 0));
if (param && !std::strcmp(il2cpp_class_get_namespace(param), "System")
&& !std::strcmp(il2cpp_class_get_name(param), "Type"))
Expand Down Expand Up @@ -153,6 +158,7 @@ struct Root {
};

Root navigation, panel, label, anomalyManager;
std::int64_t renderedSeconds = -1;

void Clear()
{
Expand All @@ -166,6 +172,7 @@ void Clear()
panel.reset();
navigation.reset();
anomalyManager.reset();
renderedSeconds = -1;
}

bool InSystemNavigation()
Expand All @@ -178,27 +185,14 @@ bool InSystemNavigation()
&& static_cast<SectionID>(section) == SectionID::Navigation_System;
}

Il2CppObject* NavigationHud()
{
static auto* screen = Class("Assembly-CSharp", "Digit.Client.UI", "ScreenManager");
static auto* top = IL2CppClassHelper(screen).GetMethodInfo("GetTopCanvas", 1);
bool visibleOnly = true;
void* args[] = {&visibleOnly};
Il2CppObject* canvas = nullptr;
if (!TryInvoke(top, nullptr, args, &canvas) || !Alive(canvas))
return nullptr;
static auto* hud = Class("Assembly-CSharp", "Digit.Prime.Navigation.UI", "HudNavigationViewController");
return WithType(TypeMethod(canvas->klass, "GetComponentInChildren"), canvas, hud);
}

Il2CppObject* ExistingAnomalyManager(Il2CppClass* managerClass)
Il2CppObject* ExistingSingleton(Il2CppClass* singletonClass)
{
// get_Instance may search the scene or create a replacement. Read only the
// native owner's existing singleton, and retry when it has not initialized.
static auto* parent = managerClass ? il2cpp_class_get_parent(managerClass) : nullptr;
auto* parent = singletonClass ? il2cpp_class_get_parent(singletonClass) : nullptr;
if (!parent || std::strcmp(il2cpp_class_get_name(parent), "MonoSingleton`1"))
return nullptr;
static auto* instance = il2cpp_class_get_field_from_name(parent, "s_instance");
auto* instance = il2cpp_class_get_field_from_name(parent, "s_instance");
if (!instance || !(il2cpp_field_get_flags(instance) & FIELD_ATTRIBUTE_STATIC) || !instance->type
|| il2cpp_type_is_byref(instance->type))
return nullptr;
Expand All @@ -207,7 +201,48 @@ Il2CppObject* ExistingAnomalyManager(Il2CppClass* managerClass)
return nullptr;
Il2CppObject* value = nullptr;
il2cpp_field_static_get_value(instance, &value);
return value && il2cpp_class_is_assignable_from(managerClass, value->klass) && Alive(value) ? value : nullptr;
return value && il2cpp_class_is_assignable_from(singletonClass, value->klass) && Alive(value) ? value : nullptr;
}

Il2CppObject* RegisteredController(Il2CppClass* controllerClass, Il2CppClass* contextClass)
{
if (!controllerClass || !contextClass)
return nullptr;
static auto* screenClass = Class("Assembly-CSharp", "Digit.Client.UI", "ScreenManager");
auto* screens = Field(ExistingSingleton(screenClass), "_screens");
int count = 0;
if (!Value(screens, "get_Count", count) || count < 0 || count > 256)
return nullptr;
auto* item = IL2CppClassHelper(screens->klass).GetMethodInfo("get_Item", 1);
for (int index = 0; index < count; ++index) {
void* args[] = {&index};
Il2CppObject* canvas = nullptr;
if (!TryInvoke(item, screens, args, &canvas) || !Alive(canvas))
continue;
auto* context = Get(canvas, "get_Context");
bool visible = false;
if (!context || !il2cpp_class_is_assignable_from(contextClass, context->klass)
|| !Value(canvas, "get_Visible", visible) || !visible)
continue;
// Search only the registered canvas that owns this context. The top
// interaction canvas and its root can belong to unrelated overlays.
// Component exposes the non-generic (Type, bool) overload. The one-argument
// overload is generic and cannot be invoked with a runtime Type object.
bool includeInactive = false;
void* controllerArgs[] = {il2cpp_type_get_object(il2cpp_class_get_type(controllerClass)), &includeInactive};
Il2CppObject* controller = nullptr;
TryInvoke(TypeMethod(canvas->klass, "GetComponentInChildren", 2), canvas, controllerArgs, &controller);
if (Alive(controller))
return controller;
}
return nullptr;
}

Il2CppObject* NavigationHud()
{
static auto* hud = Class("Assembly-CSharp", "Digit.Prime.Navigation.UI", "HudNavigationViewController");
static auto* context = Class("Assembly-CSharp", "Digit.Prime.Navigation", "NavigationViewData");
return RegisteredController(hud, context);
}

Il2CppObject* Component(Il2CppObject* object, Il2CppClass* type)
Expand Down Expand Up @@ -311,9 +346,9 @@ bool Create(Il2CppObject* nav)
Il2CppObject* name = nullptr;
if (!TryInvoke(IL2CppClassHelper(names->klass).GetMethodInfo("get_Item", 1), names, args, &name) || !Alive(name))
return false;
static auto* drawerClass = Class("Assembly-CSharp", "Digit.Prime.HUD", "HudAllianceAndNewsViewController");
auto* uiRoot = Get(Get(nav, "get_transform"), "get_root");
auto* drawer = uiRoot ? WithType(TypeMethod(uiRoot->klass, "GetComponentInChildren"), uiRoot, drawerClass) : nullptr;
static auto* drawerClass = Class("Assembly-CSharp", "Digit.Prime.HUD", "HudAllianceAndNewsViewController");
static auto* drawerContext = Class("Assembly-CSharp", "Digit.Prime.HUD", "HudAllianceAndNewsViewControllerContext");
auto* drawer = RegisteredController(drawerClass, drawerContext);
auto* chest = Get(Field(drawer, "_chestPromotion"), "get_transform");
auto* parent = Get(chest, "get_parent");
static auto* tmp = Class("Unity.TextMeshPro", "TMPro", "TextMeshProUGUI");
Expand Down Expand Up @@ -381,10 +416,16 @@ void Update()
Clear();
return;
}
static auto nextDiscovery = std::chrono::steady_clock::time_point{};
bool active = false;
if (!Alive(navigation.get()) || !Value(navigation.get(), "get_isActiveAndEnabled", active) || !active) {
Clear();
navigation.reset(NavigationHud());
if ((!Alive(navigation.get()) || !Value(navigation.get(), "get_isActiveAndEnabled", active) || !active)
&& now >= nextDiscovery) {
nextDiscovery = now + std::chrono::seconds(1);
auto* replacement = NavigationHud();
if ((replacement && replacement != navigation.get()) || !Alive(navigation.get())) {
Clear();
navigation.reset(replacement);
}
}
auto* nav = navigation.get();
bool show = false;
Expand All @@ -397,7 +438,7 @@ void Update()
// Cache the Unity object, not its timer data. Unity's liveness check detects
// destruction even while the managed wrapper is retained by our GC handle.
if (!Alive(anomalyManager.get()))
anomalyManager.reset(ExistingAnomalyManager(managerClass));
anomalyManager.reset(ExistingSingleton(managerClass));
auto* manager = anomalyManager.get();
Il2CppObject* anomaly = nullptr;
void* args[] = {&system};
Expand Down Expand Up @@ -429,9 +470,13 @@ void Update()
return;
if (show) {
auto seconds = ticks / 10000000 + (ticks % 10000000 != 0);
auto text = seconds >= 3600 ? fmt::format("{}h {:02}m {:02}s", seconds / 3600, seconds / 60 % 60, seconds % 60)
: fmt::format("{:02}m {:02}s", seconds / 60, seconds % 60);
show = Set(label.get(), "set_text", il2cpp_string_new(text.c_str()));
if (seconds != renderedSeconds) {
auto text = seconds >= 3600 ? fmt::format("{}h {:02}m {:02}s", seconds / 3600, seconds / 60 % 60, seconds % 60)
: fmt::format("{:02}m {:02}s", seconds / 60, seconds % 60);
show = Set(label.get(), "set_text", il2cpp_string_new(text.c_str()));
if (show)
renderedSeconds = seconds;
}
}
Set(panel.get(), "SetActive", &show);
}
Expand Down
Loading