fix(call): re-evaluate injected CSS when remote theme styles load - #1528
Merged
Conversation
eleboucher
force-pushed
the
fix/call-remote-theme-sync
branch
from
July 31, 2026 07:23
3903c20 to
aa3dfaf
Compare
eleboucher
marked this pull request as ready for review
July 31, 2026 07:24
The call embed iframe was not reflecting the Sable theme: - Remote/custom themes: ThemeManager injects theme CSS asynchronously into a <style> in document.head. The call's MutationObserver only watched documentElement and body attributes, so updateInjectedCSS never re-ran when the remote theme stylesheet arrived. Observe document.head so resolved variable values are picked up. - EC gradient body background: Element Call defaults to background=gradient which paints an SVG gradient via body[data-background="gradient"]::before. Pass background=solid in the widget URL params. - Iframe html dot pattern: syncStyles copies the app's own html, body rule (dot pattern) into the iframe. Clear documentElement background alongside body. - EC stylesheet cascade: Element Call loads its own stylesheets into the iframe after our injection, and uses !important at the same specificity as our overrides. Keep our injected <style> last in the iframe head and observe iframe head so our overrides keep winning the cascade.
eleboucher
force-pushed
the
fix/call-remote-theme-sync
branch
from
July 31, 2026 07:26
aa3dfaf to
7261f79
Compare
nushea
approved these changes
Jul 31, 2026
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1528-sable.raspy-dream-bb1d.workers.dev | 7261f79 | pr-1528 |
Fri, 31 Jul 2026 07:28:11 GMT |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
nushea
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Type of change
Checklist:
AI disclosure: