Repository navigation
feat: embed mirthsync 3.7.0 and expose selective deployment (0.0.5) - #3
Merged
Merged
Conversation
The plugin embeds the mirthsync CLI as a Maven dependency and calls its mainFunc in-process; 0.0.4 still bundled 3.5.1. Bump the dependency to 3.7.0 in the server and client modules (its dependency list is identical to 3.5.1, so the hand-maintained runtime whitelist still covers the closure) and the plugin to 0.0.5 in all four POMs. Engine compatibility (4.5.2, 4.6.0) is unchanged. Settings panel gains "Deploy only changed channels" (--deploy-changed) and "Also deploy new channels" (--deploy-new), mirrored through preset defaults, the preset serialization key list, snapshot/restore, and properties load/save. "Only changed" clears the other two deploy boxes (mirthsync runs every deploy flag it is given and warns); "new" is enabled only with "changed" and is cleared when it is not. Smoke-tested on OIE 4.6.0: POST /api/mirthsync/execute reports 3.7.0 and the same push --deploy-changed sequence deploys exactly the edited channel; /help lists both flags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--deploy-changed) and "Also deploy new channels" (--deploy-new), wired through presets (incl. theSETTING_KEYSserialization list), snapshot/restore, properties, argv. "Only changed" is exclusive with the other deploy boxes; "new" is enabled only with "changed".Verification
./build.shsucceeds against the Clojars artifact; generatedplugin.xmllistslibs/mirthsync-3.7.0.jar, pluginVersion 0.0.5, runtime whitelist unchanged.POST /api/mirthsync/execute-V→ 3.7.0; pull → push--deploy-changed(nothing pending) → edit → push (Deploying 1 channel(s)) →--deploy-newalone warns;/helplists both flags.