fix: support non-ASCII filenames in open-file script - #785
Open
YorkWaugh wants to merge 1 commit into
Open
Conversation
Fixes an issue where the open-file dialog fails to load files containing non-ASCII characters. This is resolved by explicitly setting the PowerShell console output encoding to UTF-8 before executing the dialog commands, ensuring compatibility with mpv's UTF-8 expectation. Fixes Samillion#780
There was a problem hiding this comment.
Pull request overview
This pull request addresses a Windows-specific mpv integration bug where open-file.lua fails to open paths containing non-ASCII characters by ensuring PowerShell emits UTF-8 text so mpv can correctly interpret selected filenames.
Changes:
- Prefixes PowerShell
-Commandcontent with a statement that sets[Console]::OutputEncodingto UTF-8. - Routes the existing dialog PowerShell script through the new UTF-8-prefixed command string.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the open-file dialog fails to load files containing non-ASCII characters. This is resolved by explicitly setting the PowerShell console output encoding to UTF-8 before executing the dialog commands, ensuring compatibility with mpv's UTF-8 expectation.
Fixes #780