verify accuracy of fractal S(q) for small q - #722
Open
pkienzle wants to merge 3 commits into
Open
Conversation
Member
|
The only change to GUI users here is the addition of the DOI for the reference to documentation which Should be accepted. The other changes are to lib files which as far as I know are not currently available through the GUI though in principle are available through scripting? Probably we just need a code review here? |
pkienzle
commented
Jun 29, 2026
krzywon
reviewed
Aug 5, 2026
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
There was a problem hiding this comment.
Our agent can fix these. Install it.
No quality gates enabled for this code.
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The equations for the fractal S(q) model were complex enough that it was not immediately obvious how they would behave at small q.
This PR rearranges the equations to make the limiting cases much more apparent, and checks them against the original equations from Teixeira (1988) using 500 bit precision.
The numpy version of the equations was added to sasmodels.special so it will be available for pure python models.