Replace np.trapz with np.trapezoid - #750
Merged
Merged
Conversation
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
There was a problem hiding this comment.
Our agent can fix these. Install it.
No quality gates enabled for this code.
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
krzywon
approved these changes
Aug 19, 2026
krzywon
left a comment
krzywon
left a comment
Collaborator
There was a problem hiding this comment.
A quick grep says you caught all np.trapz incidences. Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.trapz was removed in 2.4.0. The replacement, np.trapezoid, is in all currently supported versions of numpy, so we don't need to guard the import statements.
Most instances are in comments or exploratory code.
The only active code which uses trapezoid is in the Slit2D resolution function for oriented samples measured with slit geometry. This is only available when using sasmodels directly. SasView does not support USANS/USAXS measurements on oriented samples.