[codex] feat(dashboard): restructure curation tabs and surface LCM payload GC#214
Merged
Merged
Conversation
|
The curation panel crammed scheduler, config, run controls, proposals, skills, and the oplog into one ~6800px pane behind a sub-tab named "History". Split it into Plan / Automation / Proposals / History / Activity so automation runs and approvals are discoverable; the Proposals tab badges its pending count and resolved fact proposals collapse behind a disclosure instead of rendering disabled buttons. Add a Store Maintenance card to the LCM tab exposing the previously UI-less payloads/health and payloads/gc endpoints (preview + tokened apply), and fix payload GC to report an empty run instead of an IO error when a store has no lcm-payloads directory yet.
ScriptedAlchemy
force-pushed
the
feat/dashboard-ux-improvements
branch
from
e4a2bb4 to
ba57c31
Compare
…mprovements # Conflicts: # docs/AGENT-MEMORY-INTERCEPTION.md # docs/HERMES-LOOPS-PARITY-AUDIT.md # docs/SKILL-ADOPTION-RESEARCH.md
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Proposals tab badge now reuses usePendingAutomationCounts (the same server-side count the outer Curation badge uses) instead of deriving from locally loaded lists, which also drops the mount-time prefetch effect and its eslint suppression - extract shared CurationTabPanel scaffold (tabpanel/aria wiring, header, optional Refresh, error banner) used by the Automation, Proposals, and History panels; the Proposals panel drops its header Refresh since both sections it contains have their own - share the state pill (StateBadge) between managed skills and fact proposals instead of three copies of the markup - FactProposalsSection: drop the dead pending prop, sort once before partitioning, flatten the nested empty-state conditionals - StoreHealth: replace the reloadToken counter with a direct load callback, hoist the totals null-guard, simplify the App.tsx condition - collapse triplicated test render helpers into openTab() Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The early-return for a missing payload directory skipped the phases that only need the database: a store whose payload dir was deleted but still has externalized metadata reported 'nothing to reclaim' while the health endpoint reported missing payloads, and stale gc marks or dangling placeholders were never cleaned. existing_payload_dir_opt now reports the lazily-created directory as absent instead of erroring, the filesystem scan phases treat that as an empty listing, and delete_external_payload still performs its DB-side cleanup. Also keys the curation tab-load effects on tab activation alone via a loader ref, so selecting a skill (which recreates the loaders) no longer refetches proposals, skills, runs, and scheduler status mid-tab. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Notes