fix: address Claude review findings#247
Merged
Merged
Conversation
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
cc2b905 to
e846ec7
Compare
is_disallowed_webhook_ipv6 only checked native IPv6 ranges, so the cloud-metadata IP and loopback/private ranges were reachable via the IPv6 literal form (::ffff:169.254.169.254, ::127.0.0.1, 6to4/Teredo). Decode any embedded IPv4 and run the v4 filter on it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
e846ec7 to
f9147ae
Compare
collect_document_diagnostics dropped every diagnostic in a batch whenever diagnostics_by_uri.len() < uri_to_document.len(). For LSP servers that only publish diagnostics for files WITH problems (never an empty publish for clean files), any batch containing a clean file failed as a timeout and discarded the real diagnostics for the dirty files. Only treat the batch as a genuine timeout when NOTHING arrived (preserving the #237 behavior that a real timeout is not recorded as a complete refresh); otherwise return the diagnostics that were published. Documents the empty-publish assumption inline. Tests: reworked stdio_client_fails_when_a_document_never_publishes_diagnostics into stdio_client_returns_diagnostics_for_suppress_empty_servers (asserts the responding file's diagnostics survive) and added stdio_client_fails_when_no_document_publishes_diagnostics to lock in the zero-publish timeout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
swap_overlay_dirs restored the backup on a failed fs::rename(stage_root, overlay_root) but never removed stage_root, orphaning a .tracedecay-managed.tmp-<pid>-<nonce> directory that accumulated on every retry. Remove the staged directory in the error branch, and log a warning if the backup-restore rename also fails so the user knows content remains at the backup path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
remove_marked_block_for_target fell back to deleting the legacy unslugged managed-skills block whenever a target's own slugged block was absent. On a shared AGENTS.md mid-migration (one host slugged, another still legacy- unslugged), uninstalling the first host would delete the legacy block belonging to the second host. Only apply the legacy fallback when NO other target's slugged block is present in the file, so the legacy block can be safely assumed to be this target's. The remove-all path still removes the legacy block explicitly. Tests: added uninstall_preserves_legacy_block_on_shared_file_mid_migration, uninstall_removes_own_slugged_block_on_shared_file, and uninstall_removes_legacy_block_when_no_slugged_blocks_remain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude findings covered
Extra transcript check
Tests
TraceDecay transcript recall used to validate the missed-finding sweep.