Skip to content

Fix MSVC build of callback latency target - #12

Merged
Segfault1602 merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job
Sep 4, 2026
Merged

Fix MSVC build of callback latency target#12
Segfault1602 merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

The Windows Release build failed while compiling sfFDN.callback_latency: MSVC does not accept std::string_view iterators for std::from_chars.

  • MSVC portability
    • Pass the required character-pointer range to std::from_chars.
    • Compare the returned pointer against the corresponding pointer end.
const auto [end, error] =
    std::from_chars(value.data(), value.data() + value.size(), iterations);

Co-authored-by: Segfault1602 <3288084+Segfault1602@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job build (windows-latest, Release, cl) Fix MSVC build of callback latency target Sep 4, 2026
Copilot AI requested a review from Segfault1602 September 4, 2026 15:03
@Segfault1602
Segfault1602 marked this pull request as ready for review September 4, 2026 17:08
@Segfault1602
Segfault1602 merged commit 597e325 into main Sep 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants