Repository navigation
Conversation
Drop the Kotlin/Gradle adapter, its Python launcher, registry entry and build step, along with find_java() and the CI Java setup that existed only for it.
…ve-the-sendspin-jvm-client-adapter # Conflicts: # .github/workflows/publish.yml # README.md # adapters/sendspin-jvm/client/src/main/kotlin/com/sendspin/conformance/Main.kt # src/conformance/build.py # src/conformance/implementations.py # tests/test_undeclared_formats.py
chrisuthe
marked this pull request as ready for review
October 14, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the sendspin-jvm (Kotlin/Gradle) client adapter from the harness, along with the Java-only pieces that existed solely for it.
adapters/sendspin-jvm/andsrc/conformance/adapters/sendspin_jvm_client.pysendspin-jvmentry fromIMPLEMENTATIONS(which also stopssetup_repositories.pycloning it)_gradle_build_resultand its_build_plan()step; removefind_java()fromtoolchains.pysendspin-jvmfrom the published--tomatrixsendspin-jvmcoverage bullet; reword thetest_undeclared_formats.pymodule docstring so it doesn't name a removed implementationRegression detection only compares cases present in the current run, so the dropped jvm cases won't be flagged as regressions.
Verified:
compileall,unittest discover -s tests(16 OK), clean imports,run_all.py --help,git diff --check, andgit grep -i -E 'jvm|java|gradle|kotlin'returns nothing.