Repository navigation
Add an unpaired-access option to the TUI client - #199
Merged
Merged
Conversation
Mirror basic_client's -a flag so the TUI client can stream from a server without pairing first. Also list -u and -V in the file header's options.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused example-only change correctly preserves the default-off behavior and matches the established basic client pattern.
0 open findings
What changed in this PR
Adds opt-in unpaired access to the TUI client while keeping secure pairing as the default.
Changes:
- Adds and documents the
-aCLI flag. - Applies the setting before client startup.
- Completes the source header’s option list.
| File | Description |
|---|---|
examples/tui_client/README.md |
Documents unpaired-access usage and pairing behavior. |
examples/tui_client/main.cpp |
Parses -a and configures the client accordingly. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
-aflag toexamples/tui_clientthat callsset_unpaired_access_enabled(true)beforestart(), matchingbasic_client's-a(same usage text, same call site relative to the persistence provider andstart()).Previously, the TUI client could only stream from a server that had paired with it;
basic_clientalready lets you skip pairing for quick testing.Notes
-ain the same words asbasic_client's README.main.cppalso gains the previously missing-uand-Ventries.