Skip to content

Add an unpaired-access option to the TUI client - #199

Merged
kahrendt merged 1 commit into
mainfrom
tui-unpaired-access
Oct 12, 2026
Merged

kahrendt merged 1 commit into
mainfrom
tui-unpaired-access

Conversation

@kahrendt

@kahrendt kahrendt commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Adds a -a flag to examples/tui_client that calls set_unpaired_access_enabled(true) before start(), matching basic_client's -a (same usage text, same call site relative to the persistence provider and start()).

Previously, the TUI client could only stream from a server that had paired with it; basic_client already lets you skip pairing for quick testing.

Notes

  • README: new Run example, and the Pairing section now describes the default and -a in the same words as basic_client's README.
  • The file header's Options list in main.cpp also gains the previously missing -u and -V entries.
  • Example-only change; no library code or tests touched.

Mirror basic_client's -a flag so the TUI client can stream from a server
without pairing first. Also list -u and -V in the file header's options.
@kahrendt
kahrendt marked this pull request as ready for review October 12, 2026 15:38
@kahrendt
kahrendt requested a balanced review from Copilot October 12, 2026 15:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused example-only change correctly preserves the default-off behavior and matches the established basic client pattern.

0 open findings

What changed in this PR

Adds opt-in unpaired access to the TUI client while keeping secure pairing as the default.

Changes:

  • Adds and documents the -a CLI flag.
  • Applies the setting before client startup.
  • Completes the source header’s option list.
File Description
examples/​tui_client/​README.md Documents unpaired-access usage and pairing behavior.
examples/​tui_client/​main.cpp Parses -a and configures the client accordingly.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@kahrendt
kahrendt merged commit 98c3516 into main Oct 12, 2026
17 checks passed
@kahrendt
kahrendt deleted the tui-unpaired-access branch October 12, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants