Repository navigation
fix(daemon): log repeated admission timeouts at debug, first at info - #296
Closed
kiwipaulrob wants to merge 0 commit into
Closed
kiwipaulrob wants to merge 0 commit into
kiwipaulrob wants to merge 0 commit into
Conversation
kiwipaulrob
force-pushed
the
fix/admission-timeout-log-once
branch
from
October 17, 2026 03:39
41f98cf to
0d8c335
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When a server keeps redialing, every unadmitted connection logs the same info line, so the daemon log fills with repeats of one event:
INFO:sendspin.daemon.daemon:Incoming connection did not complete admission (handshake timed out or was aborted); waiting for a retry.
I hit this watching my own player logs, where the line repeats on every reconnect and buries everything else. This keeps the first occurrence at info (an unadmitted connection would otherwise be fully silent, as the code comment notes) and moves repeats to debug. The flag resets once a connection is admitted, so a later wedged spell is visible again at info.
No behavior change apart from log level: three lines of state (one bool, set on first log, cleared on admission).
Related issue (if applicable):
Types of changes
bugfixnew-featureenhancementbreaking-changerefactordocumentationmaintenancecidependencies