Repository navigation
Define how an in-place stream/start treats buffered visualizer data - #307
Merged
Merged
Conversation
Keep buffered frames and interpret each under the configuration in effect when it was received, matching the player role. An in-place `stream/start` does not reset the `buffer_capacity` count.
maximmaxim345
approved these changes
Oct 20, 2026
maximmaxim345
left a comment
maximmaxim345
left a comment
Member
There was a problem hiding this comment.
Nice catch, thanks @kahrendt !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visualizer role didn't define how an in-place
stream/starttreats data received under the previous configuration, whichmessaging.mdleaves to each role. Match the player: frames sent before the update keep the previous configuration, and clients keep buffered frames and interpret each under the configuration in effect when it was received. Also state that an in-placestream/startdoesn't reset thebuffer_capacitycount, as the player role does.This matches what the existing timestamp-ordering (#229) and buffer-accounting (#232) rules already assume, and what sendspin-server and the aiosendspin server do.
Closes #306
Breaking changes
sendspin-cpp: drops all buffered visualizer frames on any
stream/startand decodes at delivery time with the currentn_disp_bins. It must keep frames across an in-place start and decode each under its own configuration.I accept the Contributor License Agreement for this contribution.