Repository navigation
Make a reused Sentinel or pairing PSK a pairing protocol error - #311
Open
maximmaxim345 wants to merge 1 commit into
Open
maximmaxim345 wants to merge 1 commit into
maximmaxim345 wants to merge 1 commit into
Conversation
6 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec requires the long-term PSK to be drawn from a CSPRNG and distinct from the pairing PSK, but didn't say what the server does when a client delivers the Sentinel PSK or the pairing PSK instead. Accepting it leaves a pairing record keyed by a public constant, or by a secret anyone with the pairing token holds.
The server now treats it as a protocol error and persists nothing.