Repository navigation
Limit min_buffer_ms to 0-5000 - #313
Open
maximmaxim345 wants to merge 1 commit into
Open
maximmaxim345 wants to merge 1 commit into
maximmaxim345 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server uses one send-ahead for a whole group, the largest across its players. So a single player reporting a very large
min_buffer_msdelays playback for every player in the group.This gives
min_buffer_msa fixed range of 0-5000, the same asoutput_delay_ms, and players clamp it themselves. That is technically a breaking change for players that report larger values today.An alternative solution would be letting each server cap
min_buffer_msat its own value of at least 5000 ms. But 5s is already a really large buffer size.