Skip to content

Limit min_buffer_ms to 0-5000 - #313

Open
maximmaxim345 wants to merge 1 commit into
mainfrom
docs/min-buffer-fixed-range
Open

maximmaxim345 wants to merge 1 commit into
mainfrom
docs/min-buffer-fixed-range

Conversation

@maximmaxim345

Copy link
Copy Markdown
Member

The server uses one send-ahead for a whole group, the largest across its players. So a single player reporting a very large min_buffer_ms delays playback for every player in the group.

This gives min_buffer_ms a fixed range of 0-5000, the same as output_delay_ms, and players clamp it themselves. That is technically a breaking change for players that report larger values today.

An alternative solution would be letting each server cap min_buffer_ms at its own value of at least 5000 ms. But 5s is already a really large buffer size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant