Repository navigation
Stop client/leave from ending every stream - #316
Open
maximmaxim345 wants to merge 1 commit into
Open
maximmaxim345 wants to merge 1 commit into
maximmaxim345 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client/leaveis handled like a client becoming unavailable, which ends all active streams. This also ended the artwork stream, and since the client stays available after a leave, nothing restarted it.Now a leave ends no stream by itself, and each stream continues or ends as it would for any client in the new solo group. This keeps the artwork showing after a leave, so the client still shows what would start when play is pressed.