Repository navigation
Define auto-reconnect and reconnect clients after shutdown - #318
Open
maximmaxim345 wants to merge 1 commit into
Open
maximmaxim345 wants to merge 1 commit into
maximmaxim345 wants to merge 1 commit into
Conversation
maximmaxim345
added this pull request to stack #319
October 20, 2026 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
client/goodbyereasons didn't say whether dialing a client that shows up again in mDNS counts as an auto-reconnect.This makes it count as one, whether mDNS reports a new service or an update to a known one. Servers then also keep the no-reconnect state across their own restarts.
After
shutdown, servers now auto-reconnect like afterrestart. Waiting for mDNS doesn't work there, since a device plugged back in while its records are still in the server's mDNS cache may not show up again for a long time.For
aiosendspin, this means retrying aftershutdown, and keeping the block for the other reasons when the client's mDNS service is removed, since a reboot doesn't change why the client left.