Repository navigation
Stop buffered audio from delaying server commands and state - #320
Open
maximmaxim345 wants to merge 3 commits into
Open
maximmaxim345 wants to merge 3 commits into
maximmaxim345 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Sendspin sends everything over one WebSocket, a server filling a player's buffer can hold back volume and mute commands until the buffer is nearly full. While the send order might seem like an implementation choice, I think the spec needs to state it to avoid this.
server/command,server/stateandgroup/updatenow go out ahead of any binary role data the server hasn't started sending. Stream control messages keep their place since they have to stay in order with the audio chunks.Closes #264