Repository navigation
Define the player formats every server must produce - #323
Draft
maximmaxim345 wants to merge 3 commits into
Draft
maximmaxim345 wants to merge 3 commits into
maximmaxim345 wants to merge 3 commits into
Conversation
Member
Author
|
I'm still split on whether this should be part of the spec or just the implementation guide (and if spec, a MUST or a SHOULD for players). I think it should be in the spec, since it would be nice to guarantee that every player works with every server. But I can see it being limiting for some very limited servers and clients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec promised that a player listing
flacorpcmcan be served by every server, butbit_depth,channelsandsample_ratehad no bounds. A player listing only formats outside what a server produces (like 8-bit PCM onaiosendspin) was compliant but never got a stream, with no error sent to it.This names a set every server has to produce for
flacandpcm(16 or 24 bit, 1 or 2 channels, 44.1 or 48 kHz), and players have to list at least one entry from it.aiosendspin,sendspin-jsandsendspin-clialready fit.