Skip to content

Fix/189 misc quirks - #203

Merged
joshua-dean merged 15 commits into
mainfrom
fix/189-misc-quirks
Oct 24, 2026
Merged

joshua-dean merged 15 commits into
mainfrom
fix/189-misc-quirks

Conversation

@joshua-dean

@joshua-dean joshua-dean commented Oct 11, 2024 •

Copy link
Copy Markdown
Collaborator

Fix misc quirks found in #175

Description

Closes #189.

Changes:

  • Add nullish coalescing operators where relevant
  • Make ESLint respect .gitignore
  • Update PR template capitalization of CHANGELOG
  • Ignore .claude

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to CHANGELOG.md

Breaking API Changes

unlikely

Base automatically changed from feature/loader to rc/v0.16.0 November 8, 2024 18:25
@joshua-dean joshua-dean mentioned this pull request Nov 8, 2024
6 tasks done
Base automatically changed from rc/v0.16.0 to main December 5, 2024 21:59
joshua-dean and others added 10 commits December 5, 2024 16:01
Resolve conflicts in favor of main: the size cookie was removed (706a2ac),
drag state construction moved to build_initial_drag_state, and the
deprecated argument comments were already restructured.

Co-authored-by: joshua-dean <alder314@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: joshua-dean <alder314@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ESLint's flat config doesn't read .gitignore, so `eslint .` walked into
nested Claude Code worktrees under .claude/worktrees and linted their
build output. Load .gitignore via @eslint/compat's includeIgnoreFile and
ignore .claude.

Co-authored-by: joshua-dean <alder314@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The @eslint/compat export is deprecated. eslint/config only re-exports it
from ESLint 10 onward, so depend on @eslint/config-helpers directly.

Co-authored-by: joshua-dean <alder314@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joshua-dean joshua-dean self-assigned this Oct 22, 2026
@joshua-dean joshua-dean added the enhancement New feature or request label Oct 22, 2026
@joshua-dean
joshua-dean marked this pull request as ready for review October 22, 2026 21:10

@TrevorBurgoyne TrevorBurgoyne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@joshua-dean
joshua-dean merged commit f94a22e into main Oct 24, 2026
4 checks passed
@joshua-dean
joshua-dean deleted the fix/189-misc-quirks branch October 24, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misc quirks discovered while comparing linters

2 participants