Skip to content

Return ulabel_init - #266

Merged
joshua-dean merged 4 commits into
mainfrom
feature/264-return-init-promise
Oct 21, 2026
Merged

joshua-dean merged 4 commits into
mainfrom
feature/264-return-init-promise

Conversation

@joshua-dean

@joshua-dean joshua-dean commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Return ulabel_init so ulabel.init is awaitable

Description

Return ulabel_init so ulabel.init is awaitable.
Closes #264.

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

Typescript projects enforcing @typescript-eslint/no-floating-promises will have to type existing calls with void, or await them.

@joshua-dean joshua-dean self-assigned this Oct 19, 2026
@joshua-dean joshua-dean added bug Something isn't working enhancement New feature or request labels Oct 19, 2026

@TrevorBurgoyne TrevorBurgoyne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

couple docs thoughts, you can go ahead and bump version and tag the version in the changelog

Comment thread api_spec.md

@TrevorBurgoyne TrevorBurgoyne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump version and should be good to go. I will fix the broken firefox test in my next pr

@joshua-dean
joshua-dean merged commit 5ac4185 into main Oct 21, 2026
4 checks passed
@joshua-dean
joshua-dean deleted the feature/264-return-init-promise branch October 21, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ulabel.init should return a promise so it can be awaited

2 participants