Repository navigation
Fix demo page img not loading - #267
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Deployment paths, row sizing, test adjustments, and release versions are consistent, with no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes image loading in the GitHub Pages demo and prevents annotation-list layout shifts.
Changes:
- Uses a relative image URL and includes the image in deployment.
- Corrects reserved row height and avoids hover effects in the isolate test.
- Updates release versions to 0.30.1 and records verification.
| File | Description |
|---|---|
| tests/e2e/isolate.spec.js | Moves the cursor away before visual checks. |
| src/version.js | Updates the runtime version. |
| src/toolbox_items/annotation_list.ts | Corrects reserved content height. |
| package.json | Bumps the package version. |
| package-lock.json | Synchronizes release versions. |
| demo/live_demo.html | Makes the image URL relative. |
| CHANGELOG.md | Documents the row-sizing fix. |
| .vscode/settings.json | Adds a specific terminal auto-approval rule. |
| .github/workflows/deploy-demo.yml | Copies the demo image into deployment. |
| .github/tasks.md | Records completed fixes and verification. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix demo
AnnotationListrows behavior when not drawn yetPR Checklist
package.jsonhas been bumped since last releasepackage.jsonandsrc/version.jsapi_spec.md)changelog.mdBreaking API Changes
nah