Skip to content

Fix demo page img not loading - #267

Merged
TrevorBurgoyne merged 5 commits into
mainfrom
fix/demo
Oct 21, 2026
Merged

TrevorBurgoyne merged 5 commits into
mainfrom
fix/demo

Conversation

@TrevorBurgoyne

@TrevorBurgoyne TrevorBurgoyne commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Fix demo

  • needed to update live demo on gh pages to point to and copy over the correct local file path
  • fix AnnotationList rows behavior when not drawn yet

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

nah

@TrevorBurgoyne TrevorBurgoyne added the bug Something isn't working label Oct 19, 2026
Base automatically changed from feature/264-return-init-promise to main October 21, 2026 01:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Deployment paths, row sizing, test adjustments, and release versions are consistent, with no unresolved findings.

No open issues 🎉

What changed in this PR

Fixes image loading in the GitHub Pages demo and prevents annotation-list layout shifts.

Changes:

  • Uses a relative image URL and includes the image in deployment.
  • Corrects reserved row height and avoids hover effects in the isolate test.
  • Updates release versions to 0.30.1 and records verification.
File Description
tests/​e2e/​isolate.spec.js Moves the cursor away before visual checks.
src/​version.js Updates the runtime version.
src/​toolbox_items/​annotation_list.ts Corrects reserved content height.
package.json Bumps the package version.
package-lock.json Synchronizes release versions.
demo/​live_demo.html Makes the image URL relative.
CHANGELOG.md Documents the row-sizing fix.
.vscode/​settings.json Adds a specific terminal auto-approval rule.
.github/​workflows/​deploy-demo.yml Copies the demo image into deployment.
.github/​tasks.md Records completed fixes and verification.

Review effort: Balanced

@TrevorBurgoyne
TrevorBurgoyne merged commit 84224ae into main Oct 21, 2026
5 checks passed
@TrevorBurgoyne
TrevorBurgoyne deleted the fix/demo branch October 21, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants