Skip to content

fix: resolve minimal build blockers #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fraware merged 1 commit into from
Sep 23, 2026
Merged

fix: resolve minimal build blockers #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions runtime/sidecar-watcher/src/crypto.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ impl AsyncSigningPipeline {
pub async fn submit_request(
&self,
request: SigningRequest,
) -> Result<(), mpsc::error::SendError<SigningRequest>> {
) -> Result<(), Box<mpsc::error::SendError<SigningRequest>>> {
self.metrics.total_requests.fetch_add(1, Ordering::Relaxed);
self.metrics.queue_size.fetch_add(1, Ordering::Relaxed);
self.request_tx.send(request).await
self.request_tx.send(request).await.map_err(Box::new)
}

/// Get signing result
Expand Down Expand Up @@ -421,7 +421,7 @@ impl BatchVerifier {
signature: Signature,
public_key: VerifyingKey,
request_id: String,
) -> Result<(), mpsc::error::SendError<VerificationRequest>> {
) -> Result<(), Box<mpsc::error::SendError<VerificationRequest>>> {
let request = VerificationRequest {
message,
signature,
Expand All @@ -431,7 +431,7 @@ impl BatchVerifier {
let _ = self.batch_timeout;
let _ = self.batch_size;

self.tx.send(request).await
self.tx.send(request).await.map_err(Box::new)
}

/// Wait for verification results
Expand Down
4 changes: 3 additions & 1 deletion scripts/proto.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ PROTO_V1_DIR := api/v1
PROTO_FILES := $(wildcard $(PROTO_V1_DIR)/*.proto)
GO_PROTO_OUT := core/sdk/go/generated
TS_SDK_DIR := core/sdk/typescript
TS_PROTO_PLUGIN := $(CURDIR)/$(TS_SDK_DIR)/node_modules/.bin/protoc-gen-ts_proto
# npm workspaces may install ts-proto either under the SDK or hoist it to the
# repository root. Prefer the SDK-local plugin and fall back to the root.
TS_PROTO_PLUGIN := $(firstword $(wildcard $(CURDIR)/$(TS_SDK_DIR)/node_modules/.bin/protoc-gen-ts_proto $(CURDIR)/node_modules/.bin/protoc-gen-ts_proto))
RUST_SDK_DIR := core/sdk/rust
GOLDEN_DIR := tests/fixtures/golden
API_DOCS := docs/api/api.md
Expand Down
Loading