Remove paste from definition rule composition - #136
Open
adampetro wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/5ade7443-148c-4a48-928b-d5abe80b0212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes definition rules and visitors more consistent with the executable rules and visitors. Both validation surfaces now use the same tuple composition and construction patterns.
combine_definition_rules!with tuple-based rule compositionseq_macroimplementations for definition rule and visitor tuplesVisitorto align validation surfacespastedependencyTesting
cargo check --workspace --all-targetscargo test -p bluejay-validatorcargo test -p bluejay-validator --test definition_integration_testcargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkCloses #134