Skip to content

Collect metrics for T::InexactStruct and T::ImmutableStruct #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Morriar merged 1 commit into from
Sep 29, 2026
Merged

Collect metrics for T::InexactStruct and T::ImmutableStruct #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/spoom/sorbet/metrics/code_metrics_visitor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ def visit_class_node(node)
case node.superclass&.slice
when /^(::)?T::Struct$/
@counters.increment("t_structs")
when /^(::)?T::InexactStruct$/
@counters.increment("t_inexact_structs")
when /^(::)?T::ImmutableStruct$/
@counters.increment("t_immutable_structs")
when /^(::)?T::Enum$/
@counters.increment("t_enums")
end
Expand Down
8 changes: 7 additions & 1 deletion test/spoom/sorbet/metrics/code_metrics_visitor_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,20 @@ def test_collects_metrics_about_sorbet_structs_and_enums
context.write!("foo.rb", <<~RUBY)
class Struct < T::Struct; end
class RootStruct < ::T::Struct; end
class InexactStruct < T::InexactStruct; end
class RootInexactStruct < ::T::InexactStruct; end
class ImmutableStruct < T::ImmutableStruct; end
class RootImmutableStruct < ::T::ImmutableStruct; end
class Enum < T::Enum; end
class RootEnum < ::T::Enum; end
class Other; end
RUBY
end

assert_equal(5, metrics["classes"])
assert_equal(9, metrics["classes"])
assert_equal(2, metrics["t_structs"])
assert_equal(2, metrics["t_inexact_structs"])
assert_equal(2, metrics["t_immutable_structs"])
assert_equal(2, metrics["t_enums"])
end

Expand Down
Loading