Parse empty filter argument lists - #1295
Merged
Merged
Conversation
charlespwd
marked this pull request as ready for review
September 11, 2026 13:27
charlespwd
marked this pull request as draft
September 11, 2026 14:23
charlespwd
force-pushed
the
cp-liquid-html-parser-argument-fixes
branch
from
September 11, 2026 14:32
f308611 to
983f25e
Compare
charlespwd
changed the title
charlespwd
marked this pull request as ready for review
September 11, 2026 15:02
karreiro
approved these changes
Sep 11, 2026
karreiro
left a comment
karreiro
left a comment
Contributor
There was a problem hiding this comment.
Thank you, @charlespwd!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Parse a filter colon followed by the end of markup or another filter as an empty argument list.
These forms now produce a structured
LiquidVariablewith an emptyargsarray, and the filter range includes the colon:{{ 'key' | t: }} {{ 'key' | t: | escape }}Malformed arguments such as
{{ 'key' | t: @ }}continue to use string markup. Tests cover strict Liquid and LiquidHTML parsing, tolerant parsing, filter ranges, andechotags.What's next? Any followup issues?
None.
Tophatting
Run
CI=1 pnpm testfrom the repository root.Before you deploy
changeset.