Fix several Theme Check paper cuts - #1301
Merged
Merged
Conversation
These are meaningful because Liquid always parses them as literals. For example, an @PARAM true value could be passed but never referenced as a variable—{{ true }} is always Boolean true.
Allow ValidVisibleIf to resolve variables assigned by the Liquid file, and count references from valid visible_if expressions when checking for unused assignments.
JSON templates already connect to their implicit layout, so snippets rendered by that layout are included in the graph. Liquid templates did not establish the same connection, leaving valid layout-rendered snippets incorrectly reported as orphaned.
Treat layouts as graph entry points and follow {% block %} dependencies so direct and transitive snippet references are discovered consistently.
aswamy
approved these changes
Sep 15, 2026
aswamy
left a comment
aswamy
left a comment
Contributor
There was a problem hiding this comment.
Couple of tweaks recommended but overall good approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
This PR fixes several small gaps across Theme Check:
fetchpriority="high"{% block %}referencesEach fix includes regression coverage and its own patch changeset.
Before you deploy