Skip to content

Fix stray > before a textarea that directly follows an element #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwy404 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

Fix stray > before a textarea that directly follows an element #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/textarea-borrowed-closing-tag.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/prettier-plugin-liquid': patch
---

Fix a stray `>` being printed before a `<textarea>` that directly follows another element.
1 change: 0 additions & 1 deletion packages/prettier-plugin-liquid/src/printer/print/element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export function printElement(

if (shouldPreserveContent(node)) {
return [
printOpeningTagPrefix(node, options),
group(printOpeningTag(path, options, print, attrGroupId), {
id: attrGroupId,
}),
Expand Down
4 changes: 4 additions & 0 deletions packages/prettier-plugin-liquid/src/test/html-element/fixed.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,7 @@ printWidth: 30
aaaaaaaaaaaaaaaaaaaaaaaa
</span></a
>

it should not print the borrowed closing tag end marker twice before a textarea
<div><label for="x">Name</label><textarea id="x" rows="4"></textarea></div>
<div><img src="a"><textarea>hi</textarea></div>
4 changes: 4 additions & 0 deletions packages/prettier-plugin-liquid/src/test/html-element/index.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,7 @@ it should borrow the closing span in this situation
printWidth: 30
<a class="link animate-arrow" ><span class="icon-wrap">&nbsp;{% render 'icon-arrow' %}</span></a>
<a class="link animate-arrow" ><span class="icon-wrap">&nbsp; aaaaaaaaaaaaaaaaaaaaaaaa </span></a>

it should not print the borrowed closing tag end marker twice before a textarea
<div><label for="x">Name</label><textarea id="x" rows="4"></textarea></div>
<div><img src="a"><textarea>hi</textarea></div>
Loading