fix: bound and short-circuit the ToxicDelete deadlock on dead sinks - #760
Open
matheusgb wants to merge 1 commit into
Open
fix: bound and short-circuit the ToxicDelete deadlock on dead sinks#760matheusgb wants to merge 1 commit into
matheusgb wants to merge 1 commit into
Conversation
Toxics (noop, latency) forwarded chunks with a plain, unbounded `stub.Output <- chunk`. If nothing was left reading that channel, the send blocked forever and could never be interrupted, so RemoveToxic hung while holding the collection's mutex, freezing the whole control API (reads included). - ToxicStub.OutputDone and ToxicLink.writeDone let a send react instantly when the next toxic already closed itself, or the real destination connection already died. - Otherwise, the send is bounded by a timeout derived from the chain's own configured delay, so a legitimately slow chain isn't mistaken for a dead one. - Draining a removed toxic's leftover queue no longer retries a known-dead sink item by item. Fixes Shopify#558, Shopify#427, Shopify#428.
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toxics (noop, latency) forwarded chunks with a plain, unbounded
stub.Output <- chunk. If nothing was left reading that channel, the send blocked forever and could never be interrupted, so RemoveToxic hung while holding the collection's mutex, freezing the whole control API (reads included).Fixes #558, #427, #428.