Fix Tenzir error flood on Kubernetes: suppression checks a string that is never returned - #7
Open
torvalstrom wants to merge 1 commit into
Open
Conversation
… returned
deployTenzirNode() returns "Tenzir not implemented for k8s" when
isKubernetes is true, but sendPipelineHealthStatus() suppresses the error
log by testing for "Kubernetes not implemented for Tenzir node". Those two
strings never match, so the suppression never fires and every Kubernetes
deployment logs
[ERROR] Tenzir node connection problem: Tenzir not implemented for k8s
on every poll - roughly one line every two seconds, indefinitely.
That the quiet path is intended is clear from the else branch, which
carries a commented-out tenzirDisabled = true and a debug-level
"Disabling pipelines" message.
Neither string appears anywhere else in the repository, so this points the
existing check at the message that is actually produced. Users can already
work around it by setting SHUFFLE_SKIP_PIPELINES=true, which is matched by
the same condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Kubernetes, Orborus logs this on every pipeline health poll — about one line every two seconds, indefinitely:
On one cluster that is ~43,000 lines per day shipped into central logging.
Cause
deployTenzirNode()returns the error"Tenzir not implemented for k8s"when running under Kubernetes:sendPipelineHealthStatus()tries to suppress exactly this case, but tests for a different string —"Kubernetes not implemented for Tenzir node":The two strings never match, so the
elsebranch is unreachable for the Kubernetes case and the error is logged every time. The commented-outtenzirDisabled = trueand the debug-level "Disabling pipelines" message show the quiet path is what was intended.Fix
Point the existing check at the message that is actually produced. Neither string occurs anywhere else in the repository, so this is a one-line change with no other call sites affected.
Notes
SHUFFLE_SKIP_PIPELINES=true, which the same condition matches. That is what I am running in the meantime.nightly; the same mismatch is present onmain.