feat: Added support for running direct tool calls by the agent - #443
Merged
Conversation
…or direct app calls
frikky
reviewed
Aug 4, 2026
| func runAgentDecisionDirectAppCall(execution WorkflowExecution, decision AgentDecision) (rawResult []byte, debugUrl string, appName string, categoryLabels []string, actionName string, err error) { | ||
| ctx := context.Background() | ||
| minUser := User{ | ||
| Username: execution.Workflow.Owner, |
Member
There was a problem hiding this comment.
This won't necessarily work long-term. Using org -> lookup user somehow is almost always better
| } | ||
| } | ||
|
|
||
| requestUrl := fmt.Sprintf("%s/api/v1/apps/%s/run?delete=false&execution_id=%s&authorization=%s&org_id=%s&timeout=115", baseURL, resolvedAppId, execution.ExecutionId, execution.Authorization, execution.ExecutionOrg) |
Member
There was a problem hiding this comment.
Why such a high timeout? Is it necessary? And why so specific at 115?
Most of our apps time out at 60 seconds, or even 30 seconds by default. That is the app itself.
| return body, debugUrl, appName, []string{}, "", err | ||
| } | ||
|
|
||
| skipSingul := executionMode == "direct" || os.Getenv("AGENT_SKIP_SINGUL") == "true" |
Member
There was a problem hiding this comment.
ah, neat.
We need to clean up environment variables soon lol
…m the organization if available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?