Repository navigation
Support pySigma 2.0 - #16
Draft
cristianchiriac wants to merge 1 commit into
Draft
cristianchiriac wants to merge 1 commit into
cristianchiriac wants to merge 1 commit into
Conversation
pySigma 2.0.0 was released on 2026-10-04. Raise the dependency to pysigma>=2.0.0,<3.0 and refresh poetry.lock. pySigma 2.0 requires Python 3.11, so drop 3.10 from requires-python and the test matrix, and build the minimum supported SQLite on the 3.11 job. pySigma 2.0 expands an IPv6 CIDR whose network ends in zero groups to both the uncompressed and the compressed prefix, so 2001:db8::/64 now also matches '2001:db8:0:0:%'. Update the expected query.
Author
|
Update: the red CI here is not caused by this change. pySigma 2.0.0 turned Correction to the description above: my local runs that passed used a non-editable install of this backend ( |
cristianchiriac
marked this pull request as draft
October 5, 2026 16:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pySigma 2.0.0 was released yesterday. The backend currently requires
pysigma>=1.5.1,<2.0, so it can't be installed alongside it.Changes
pyproject.toml:pysigma>=2.0.0,<3.0.poetry.lockwas regenerated withpoetry lock. The only resolved changes are pysigma 1.5.1 → 2.0.0, the newgoogle-re2dependency, and removal of the 3.10-onlyexceptiongroup/tomli.pysigma (2.0.0) requires Python <4.0,>=3.11), so:requires-pythonis now>=3.11,<4.0;test_sqlite_cidr_ipv6_prefix_ending_in_zero_groups: pySigma 2.0 expands2001:db8::/64to the uncompressed prefix as well as the compressed one. The expected query is nowfield LIKE '2001:db8:0:0:%' ... OR field LIKE '2001:db8::%' .... The previous expectation is kept in the comment for context.Testing: after
poetry install(pySigma 2.0.0, Python 3.11),pytestgives 162 passed and 16 skipped. Without the test change, onlytest_sqlite_cidr_ipv6_prefix_ending_in_zero_groupsfails. I found no other behavior differences in the test suite.