Clarify browser support and repair shared candidate qualification - #28
Merged
Merged
Conversation
sarthakagrawal927
marked this pull request as ready for review
October 4, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signed app’s support wording advertised Brave/Chromium-family support while tab Automation targets Chrome. Candidate CI also stopped before testing because its shared tooling pin expected the retired repository owner. This aligns the two support strings with the current supported browser policy and pins candidate CI to the reviewed producer that accepts
Significant-Hobbies/browserdaddy.The consumer now includes the exact canonical
appcast_core.pyand integrates it into the app-owned preparation wrapper. The wrapper preserves BrowserDaddy’s signing account, protected-key handling, update URL, codesign verification and stapler validation, while rejecting ambiguous checksums, invalid artifacts, mismatched enclosure URL/length/signature metadata and staged-byte drift. The release workflow and native permissions retain their existing configuration.Validation at source head
c24b1f8333d36c179a6ba3695629d4ce69570f3a:de31581b56fa8b6c20a03d0846ad2204aa2c9bab; producer contract and shared appcast fixture suites pass.These fixtures qualify source behavior and signature metadata shape. Cryptographic verification, installed update behavior, broader browser Automation and background routing acceptance remain separate open work.
Related: #23, #25, sass-maker/saas-maker#151. This draft does not close those issues.