Repository navigation
fix(tests): deflake draft-restore relaunch test - #101
Merged
Merged
Conversation
@AppStorage writes flush to UserDefaults asynchronously — terminate() immediately after typeText could kill the app mid-flush ("Keep my dr" instead of "Keep my draft"). Wait for the write to settle, wait for the field to exist before typing, and poll the restored value instead of an instant assert. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testOnboardingRestoresFoodDraftAcrossRelaunchflaked on main (alternating pass/fail):@AppStoragewrites flush to UserDefaults asynchronously, soterminate()right aftertypeTextcould kill the app mid-flush — observedOptional("Keep my dr")vsOptional("Keep my draft").expectation(for:evaluatedWith:)instead of an instant assert.Test plan
native-quality— the flaky test should pass deterministicallyGenerated with Devin