Skip to content

Keep exploration target-free and native food editor labels visible - #111

Merged
sarthakagrawal927 merged 9 commits into
mainfrom
codex/issue-110-explore-without-targets
Oct 4, 2026
Merged

sarthakagrawal927 merged 9 commits into
mainfrom
codex/issue-110-explore-without-targets

Conversation

@sarthakagrawal927

@sarthakagrawal927 sarthakagrawal927 commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Choosing Explore Calorie first keeps targets unset and allows logging. Stored target choices and existing entries are preserved. The native food editor keeps Name, Serving and nutrient labels visible with kcal/gram units and accessible labels at default and enlarged text. Recorded-day and serving copy now uses singular or plural wording for the count.

Fixes #110, #112, and #113.

Verification at head 84f3567fd68d709562650b17888e0d5c2ffc5546:

  • CI run 37174640538 passed the full quality and native-quality gates, including exploration without targets, edit/save/reopen at both text sizes, and singular/plural counts.
  • Two fixture-isolated UI cases also passed locally on iPhone 17 Pro / iOS 26.5 (186.5 seconds): food-editor labels/save and recorded-day/serving counts. Each uses a new fictional UUID journal with nil cloud/legacy adapters and verifies its scoped cleanup.
  • Exported screenshots and accessibility hierarchies were independently reviewed at default and Accessibility XXXL sizes. Nutrient labels remain visible; enlarged labels wrap and the form scrolls. The long fictional Name value ellipsizes in its single-line field, while the full value remains accessible.
  • The exploration UI case was verified in ephemeral CI; it was not rerun against the persistent local simulator because its reset helper is unscoped.

This preserves the established native Form and navigation. No installed-device, VoiceOver, App Store release or owner-acceptance claim is made. Historical evidence is retained privately in the fleet-pr-issue-audit-2026-10-04 report.

@sarthakagrawal927
sarthakagrawal927 marked this pull request as draft October 2, 2026 18:12
@sarthakagrawal927

Copy link
Copy Markdown
Member Author

Source correction is now pushed at c21d3e637baf484966dfabf44ecbb66de2fb8054. New profiles have nil targets; Explore marks completion without clearing stored manual/equation choices or journal entries; maintained core and AppModel regressions.

Validation: Five core fixtures passed; root independently passed all four current AppModel/store tests on the dedicated Calorie Audit simulator with a unique persistent fixture journal and nil cloud/legacy adapters. Native visual/VoiceOver and canonical telemetry acceptance remain unqualified.

This PR remains draft, unmerged and unreleased. No real account/provider/analytics, cloud configuration or personal data actions were performed.

@sarthakagrawal927 sarthakagrawal927 changed the title fix: keep Explore-first targets unset Keep exploration target-free and native food editor labels visible Oct 2, 2026
@sarthakagrawal927
sarthakagrawal927 marked this pull request as ready for review October 4, 2026 14:58
@sarthakagrawal927
sarthakagrawal927 merged commit cb206d2 into main Oct 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not assign targets when exploring before setup

1 participant