Repository navigation
WEB-1194: Read the vcs repositories with git instead of the GitHub API - #35
Merged
Merged
Conversation
…I (no-api) A lockless composer install cost about 100 GitHub API requests of the token's hourly quota, enough to exhaust it in a busy CI (Could not authenticate against github.com). no-api makes Composer read tags with git: zero API requests, same resolved versions. Applied to the development dependencies and the README snippet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CI of the plugin PRs failed with
Could not authenticate against github.com. Root cause: a locklesscomposer installthroughvcsrepositories spends about 100 GitHub API requests (measured: 102 with a cold cache, 30 with a warm one). A pull request with ~15 jobs is ~1,500 requests, and the quota (5,000 per hour) belongs to the token's owner, so it was exhausted (remaining: 0) and Composer fell back to a prompt that cannot run in CI.What
composer.json:"no-api": trueon thevcsentries of the development dependencies. Composer then reads tags with git instead of the API.[Unreleased]): same option, with the reason.Verification
vcsentries: 0 API requests, same versions (coding-standards v1.0.1, wp-coding-standards v1.1.7, wp-github-updater v1.4.0, wp-plugin-kernel v1.0.1, wp-settings-hub v1.2.2).Docs and configuration only, no release needed.