Skip to content

[3.0] Parse memory settings that carry no unit designator #9324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sesquipedalian merged 1 commit into from
Aug 14, 2026
Merged

[3.0] Parse memory settings that carry no unit designator #9324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions Sources/Sapi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,19 +334,28 @@ public static function setMemoryLimit(string $needed, bool $in_use = false): boo
/**
* Helper function to convert memory string settings to bytes
*
* @param string $val The byte string, like '256M' or '1G'.
* The shorthand notation PHP accepts for these settings is optional, so the
* value may be a plain byte count with no designator at all.
*
* A negative value means there is no limit, which is reported as PHP_INT_MAX
* so that callers comparing it against an amount of memory they need do not
* have to special case it.
*
* @param string $val The byte string, like '256M', '1G' or '2097152'.
* @return int The string converted to a proper integer in bytes.
*/
public static function memoryReturnBytes(string $val): int
{
if (\is_integer($val)) {
return (int) $val;
$val = trim($val);

// No limit at all.
if ((int) $val < 0) {
return PHP_INT_MAX;
}

// Separate the number from the designator.
$val = trim($val);
$num = \intval(substr($val, 0, \strlen($val) - 1));
// Separate the number from the designator, if there is one.
$last = strtolower(substr($val, -1));
$num = \in_array($last, ['g', 'm', 'k'], true) ? (int) substr($val, 0, -1) : (int) $val;

// Convert to bytes.
switch ($last) {
Expand Down
Loading