Skip to content

[3.0] Give every poll choice the same id, whichever code built it #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sesquipedalian merged 2 commits into from
Aug 30, 2026
Merged

[3.0] Give every poll choice the same id, whichever code built it #9434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4c2d7b
Gives every poll choice the same id, whichever code built it
albertlast Aug 9, 2026
cb30967
Update Sources/Poll.php
Sesquipedalian Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Poll.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ public function format(array $format_options = []): array

// Now add it to the poll's contextual theme data.
$this->formatted['choices'][$i] = [
'id' => 'options-' . $i,
'id' => $i,
'number' => ++$choice_number,
'percent' => $bar,
'votes' => $option->votes,
Expand Down
4 changes: 2 additions & 2 deletions Sources/ServerSideIncludes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,7 +1875,7 @@ public static function recentPoll(bool $topPollInstead = false, string $output_m

foreach ($return['options'] as $option) {
echo '
<label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>';
<label for="options-', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>';
}

echo '
Expand Down Expand Up @@ -1966,7 +1966,7 @@ public static function showPoll(?int $topic = null, string $output_method = 'ech

foreach ($return['options'] as $option) {
echo '
<label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>';
<label for="options-', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>';
}

echo '
Expand Down
2 changes: 1 addition & 1 deletion Themes/default/Display.template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function template_main()
// Show each option with its button - a radio likely.
foreach (Utils::$context['poll']['options'] as $option) {
echo '
<li>', $option['vote_button'], ' <label for="', $option['id'], '">', $option['option'], '</label></li>';
<li>', $option['vote_button'], ' <label for="options-', $option['id'], '">', $option['option'], '</label></li>';
}

echo '
Expand Down
Loading