Skip to content

[3.0] Answer a personal message link that points at nothing #9464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sesquipedalian merged 1 commit into from
Aug 29, 2026
Merged

[3.0] Answer a personal message link that points at nothing #9464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Sources/PersonalMessage/Folder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,12 +163,24 @@ public function show(): void
// @todo Can we consolidate these into a single variable?
foreach (['pmid', 'pmsg'] as $var) {
if (isset($_GET[$var])) {
$this->requested_pm = current(PM::load((int) $_GET[$var]));
$id = (int) $_GET[$var];

// Anything that is not a real ID never reaches the database:
// PM::load() answers an empty array of IDs with "given array of
// integer values is empty", which is a 500 for a URL a member
// only has to mistype.
$requested_pm = $id > 0 ? current(PM::load($id)) : false;

// Make sure you have access to this PM.
if (!$this->requested_pm->canAccess($this->is_inbox ? 'inbox' : 'sent')) {
// PM::load() also finds nothing for an ID that has been pruned
// or was never real, and current() answers false for that,
// which is not something $requested_pm can hold. A PM that is
// not there is no more accessible than somebody else's.
if (!($requested_pm instanceof PM) || !$requested_pm->canAccess($this->is_inbox ? 'inbox' : 'sent')) {
ErrorHandler::fatalLang('no_access', false);
}

$this->requested_pm = $requested_pm;
}
}

Expand Down