Skip to content

[3.0] Ensures properties are always initialized (even if null) in SMF\Url #9583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sesquipedalian merged 1 commit into from
Aug 30, 2026
Merged

[3.0] Ensures properties are always initialized (even if null) in SMF\Url #9583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions Sources/Url.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ function ($matches) {

foreach (['scheme', 'host', 'port', 'user', 'pass', 'path', 'query', 'fragment'] as $prop) {
// Clear out any old value.
unset($this->{$prop});
$this->{$prop} = null;

// Set the new value, if any.
if (isset($parsed[$prop])) {
Expand All @@ -445,28 +445,28 @@ function ($matches) {

switch ($component) {
case PHP_URL_SCHEME:
return $this->scheme ?? null;
return $this->scheme;

case PHP_URL_HOST:
return $this->host ?? null;
return $this->host;

case PHP_URL_PORT:
return $this->port ?? null;
return $this->port;

case PHP_URL_USER:
return $this->user ?? null;
return $this->user;

case PHP_URL_PASS:
return $this->pass ?? null;
return $this->pass;

case PHP_URL_PATH:
return $this->path ?? null;
return $this->path;

case PHP_URL_QUERY:
return $this->query ?? null;
return $this->query;

case PHP_URL_FRAGMENT:
return $this->fragment ?? null;
return $this->fragment;

default:
return $parsed;
Expand Down
Loading