[3.0] Records in AGENTS.md what code comments should say - #9584
Merged
Sesquipedalian merged 1 commit intoAug 30, 2026
Merged
Conversation
Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review feedback on #9573 that is worth keeping, since it applies to every pull request an
agent opens rather than to that one:
AGENTS.mdgets a### Commentssubsection under Conventions to follow saying so. Itstates the rule, quotes the note, and shows the before and after from that review: a
four-line comment arguing about
invalid_dateandEvent(-1)became// Only try to set the start and duration if we were given the relevant data.Three consequences are spelled out, because each one came up on that PR:
reword. One of the three flagged on [3.0] Open the calendar's event form on a date instead of refusing to open #9573 was removed outright.
and conversational" line still stands, and the new text says so, so the two are not read
as being in tension.
Documentation only; no code changes and nothing for the test suite to reach.
Issues References (Fixes|Related|Closes)
Related to #9573, where the feedback was given.