Matter Switch: Fix Electrical profiling coroutine errors and improve fallback handling - #3150
Merged
Merged
Conversation
|
Channel deleted. |
|
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against df177dc |
Test Results 73 files 540 suites 0s ⏱️ Results for commit df177dc. ♻️ This comment has been updated with latest results. |
hcarter-775
force-pushed
the
update/energy-struct-error-handling
branch
from
July 30, 2026 16:50
f210a13 to
df177dc
Compare
hcarter-775
changed the title
hcarter-775
requested review from
NoahCornell,
cjswedes,
ctowns,
gharveymn and
tpmanley
July 30, 2026 17:00
cjswedes
approved these changes
Jul 30, 2026
ctowns
approved these changes
Jul 30, 2026
| is_optional = true, | ||
| data_type = require "st.matter.data_types.Uint64", | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
Do we also need to make these updates in matter-thermostat and matter-energy where this is also defined via an embedded cluster definition?
Contributor
Author
There was a problem hiding this comment.
I don't think it matters in those drivers. 1. Nobody is using them 2. Even if they were, there'd be no real side effects of the coroutine error for them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This attempts to improve some open issues in Electrical Sensor handling:
This solves the following issue: #3147
Summary of Completed Tests
Unit tests continue to pass. Tested on-device: https://community.smartthings.com/t/driver-for-tp-link-tapo-p316m/310364.