SONOFF/SWV1C by yanggx24 · Pull Request #3157 · SmartThingsCommunity/SmartThingsEdgeDrivers

yanggx24 · 2026-07-31T05:46:07Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

KKlimczukS · 2026-07-31T09:24:11Z

@@ -0,0 +1,14 @@
+name: sonoff-irrigation


Please rename this profile to valve-battery

KKlimczukS · 2026-07-31T09:27:00Z

+--[[
+Description: SONOFF Water Valve sub-driver for zigbee-valve
+Version: 1.2
+Author: guoxin.yang
+Date: 2026-07-06
+--]]


Please change this comment to:

-- Copyright 2026 SmartThings, Inc. -- Licensed under the Apache License, Version 2.0

KKlimczukS · 2026-07-31T09:27:55Z

+local PowerConfiguration = zcl_clusters.PowerConfiguration
+local utils = require "st.utils"
+
+-- 电池轮询间隔（秒）：SWV1C 是电池休眠设备，每 2 小时轮询一次


Please use english language in You comments (remark applies to all files)

KKlimczukS · 2026-07-31T09:28:05Z

+-- 电池轮询间隔（秒）：SWV1C 是电池休眠设备，每 2 小时轮询一次
+local BATTERY_POLL_INTERVAL = 7200
+
+-- SWV1C 设备指纹匹配表


Please use english language in You comments (remark applies to all files)

KKlimczukS · 2026-07-31T09:28:12Z

+--- OnOff 属性上报处理器 → valve 能力点事件
+--- 必须显式处理，因为子驱动定义了 capability_handlers 后，
+--- 父驱动的默认 OnOff→valve 映射会被跳过（只剩 OnOff→switch）


Please use english language in You comments (remark applies to all files)

KKlimczukS · 2026-07-31T09:28:36Z

+  device:send(OnOff.attributes.OnOff:read(device))
+end
+
+--- valve.close 能力点处理器


Please use english language in You comments (remark applies to all files)

KKlimczukS · 2026-07-31T09:28:40Z

+  device:send(OnOff.attributes.OnOff:read(device))
+end
+
+--- 设备匹配检查


Please use english language in You comments (remark applies to all files)

KKlimczukS · 2026-07-31T09:28:44Z

+  },
+  zigbee_handlers = {
+    attr = {
+      -- OnOff 属性上报 → valve 事件（弥补父驱动默认映射被跳过的缺陷）


Please use english language in You comments (remark applies to all files)

KKlimczukS · 2026-07-31T09:28:49Z

+      [OnOff.ID] = {
+        [OnOff.attributes.OnOff.ID] = onoff_attr_handler
+      },
+      -- 电池百分比属性上报 → battery 事件


Please use english language in You comments (remark applies to all files)

KKlimczukS · 2026-07-31T09:30:29Z

+-- Copyright 2022 SmartThings
+--
+-- Licensed under the Apache License, Version 2.0 (the "License");
+-- you may not use this file except in compliance with the License.
+-- You may obtain a copy of the License at
+--
+--     http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.


Please change this comment to:

-- Copyright 2026 SmartThings, Inc. -- Licensed under the Apache License, Version 2.0

KKlimczukS · 2026-07-31T09:41:20Z

+    [capabilities.valve.ID] = {
+      [capabilities.valve.commands.open.NAME] = valve_open_handler,
+      [capabilities.valve.commands.close.NAME] = valve_close_handler,
+    }
+  },


Did You check if Your device works with the zigbe-valve driver default handling ? (without this custom handling)

KKlimczukS · 2026-07-31T09:54:58Z

+      [OnOff.ID] = {
+        [OnOff.attributes.OnOff.ID] = onoff_attr_handler
+      },


Did You check if Your device works with the zigbe-valve driver default handling ? (without this custom handling)

github-actions · 2026-07-31T09:55:40Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-07-31T09:55:40Z

Profile category check: ✅ Passed - all profiles have a category defined.

github-actions · 2026-07-31T09:56:19Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/gV2qEO1Qp929

github-actions · 2026-07-31T09:57:14Z

zigbee-valve_coverage.xml

File	Coverage
All files	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/sonoff/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-valve/src/sinope/init.lua	`97%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against d3ca759

github-actions · 2026-07-31T09:57:20Z

Test Results

73 files 541 suites 0s ⏱️
3 246 tests 3 240 ✅ 0 💤 6 ❌
5 243 runs 5 233 ✅ 0 💤 10 ❌

For more details on these failures, see this check.

Results for commit d3ca759.

yanggx24 · 2026-08-01T03:02:58Z

Thanks for the review.

Yes, I checked this behavior with the SONOFF SWV1C device. The device uses the Zigbee OnOff cluster for valve control and reports the valve state through the OnOff attribute.

The custom handlers were added to explicitly map:

valve.open / valve.close commands to Zigbee OnOff On / Off
OnOff attribute reports back to SmartThings valve.open / valve.closed events

This is also needed because the device reports the OnOff value as ZCL_DATA_TYPE_UINT8. In Lua, numeric 0 is truthy, so the handler explicitly checks for false and 0 to avoid treating an OFF report as open.

I can also re-test without the custom handlers and confirm whether the default zigbee-valve handling covers this device correctly.

feat:sonoff swv valve

d3ca759

KKlimczukS requested changes Jul 31, 2026

View reviewed changes

KKlimczukS reviewed Jul 31, 2026

View reviewed changes

KKlimczukS requested a review from cbaumler July 31, 2026 09:59

Zigbee Valve:modify comment language and file name

244e0ee

yanggx24 force-pushed the main branch from 53138de to 244e0ee Compare August 1, 2026 02:44

Uh oh!

Conversation

yanggx24 commented Jul 31, 2026

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Test Results

Uh oh!

yanggx24 commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants