Cap def download - #3160
Open
varzac wants to merge 2 commits into
Open
Conversation
|
Invitation URL: |
|
All capability definitions downloaded successfully. |
Test Results 73 files 540 suites 0s ⏱️ Results for commit 9f75ddc. ♻️ This comment has been updated with latest results. |
|
zigbee-bed_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9f75ddc |
aleclorimer
reviewed
Jul 31, 2026
| env: | ||
| CAPABILITY_PAT: ${{ secrets.CAPABILITY_DEFINITIONS_PAT }} | ||
| - name: Report capability download failures | ||
| if: github.event_name == 'pull_request' && hashFiles('capability_failures_comment.md') != '' && always() |
Contributor
There was a problem hiding this comment.
github.event_name == 'pull_request' is unnecessary as this workflow will only fire on PRs
aleclorimer
reviewed
Jul 31, 2026
| import sys | ||
| import time | ||
| from pathlib import Path | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| from typing import List, Tuple, Set, Dict |
Then all the subscripted type hints changed with it too
aleclorimer
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for downloading current capability definitions for use in running tests. This ensures that tests match the current hub environment.