Conversation
- next 15.5.25, eslint-config-next 15.5.25 (EOL 14.x line CVEs) - react/react-dom 19.2.8 pinned, @types/react(-dom) 19 - react-quill -> react-quill-new 3.8.3 (react-quill uses findDOMNode, removed in React 19); react-leaflet 5; @hello-pangea/dnd 18; @testing-library/react 16 + @testing-library/dom 10 - async request APIs: await cookies() in shared/auth/cookies.ts; params/searchParams as Promise in pages and admin-proxy route context - next.config.js: serverComponentsExternalPackages -> serverExternalPackages - review-inbox-v2: JSX namespace via react import Co-Authored-By: Newbie Smart <smartnewb2@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Owner
Author
Owner
Author
|
이 PR의 커밋은 main에 머지 커밋 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
H1 항목: EOL인 Next.js 14.2.35에 누적된 미해결 Critical/High CVE(RSC DoS GHSA-5j59-xgg2-r9c4 등)를 정리하기 위해 15.x 최신 안정판(15.5.25)으로 업그레이드. #44(security-hardening) 위에 쌓인 PR —
next.config.js를 양쪽에서 건드려서 base를 해당 브랜치로 지정. #44 머지 후 자동으로 main으로 리타겟됩니다.의존성:
next14.2.35 → 15.5.25,eslint-config-next동일 버전react/react-dom→ 19.2.8 핀(@react-three/fiberpeer가>=19 <19.3이라 캐럿 범위가 19.3.0을 잡으면 충돌),@types/react(-dom)19react-quill→react-quill-new@3.8.3— react-quill은 React 19에서 제거된findDOMNode를 써서 마운트 시 크래시; 유지 fork로 교체(임포트/CSS 경로만 변경, API 동일)react-leaflet4 → 5(React 19 지원),@hello-pangea/dnd16 → 18,@testing-library/react16 +@testing-library/dom10(devDep)코드 변경(Next 15 async request APIs):
shared/auth/cookies.ts:cookies()→await cookies()(7곳; 호출자는 이미 모두 async wrapper await)params/searchParamsPromise화:ai-profiles/generator/[id],ai-profiles/ghosts/users/[userId],push-groups/[id]/edit— 라우트 핸들러(kb-candidates 등)는 이미Promise<params>형태였음admin-proxy컨텍스트 타입을params: Promise<AdminProxyRouteParams>로 확정(기존 union은 Next 15 타입 검증 실패)next.config.js:experimental.serverComponentsExternalPackages→serverExternalPackagesreview-inbox-v2: React 19에서 제거된 글로벌JSX네임스페이스 →import type { JSX } from 'react'Checks:
pnpm typecheck:admin-v2✓,pnpm lint:admin-v2✓(0 errors),pnpm test:admin✓ 123/123,pnpm build✓ (Next 15.5.25)Material limits: 브라우저 E2E 미실행 — react-quill-new/리플릿 지도 등 마이그레이션된 컴포넌트의 실제 렌더링은 배포 전 스테이징 확인 권장.
experimental.serverActions키는 15에서도 유효(빌드 로그에 experiments 표기만).Link to Devin session: https://app.devin.ai/sessions/28aeed4402ec4a02a3f6a6138f4899d0
Open in Devin Desktop: https://app.devin.ai/desktop/session/28aeed4402ec4a02a3f6a6138f4899d0?variant=devin
Requested by: @Smartnewb