Repository navigation
Accept pylibsparseir 0.14, skip 0.13; release 2.1.7 - #97
Merged
Merged
Conversation
pylibsparseir 0.14 refuses to load on a CPU without FMA with a clear error. 0.13 needs FMA too but crashes with SIGILL there, so it stays out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylibsparseirrange inpyproject.tomland.conda/meta.yaml:>=0.8.3,<0.13.0->>=0.8.3,!=0.13.*,<0.15.0.RuntimeError(Expose whether the build may use FMA (spir_cpu_has_fma) so the bindings can fail with a clear error sparse-ir-rs#332).SPIR_SVDSTRAT_*constants removed; no signature changed.pylibsparseirwithout FMA (from the git tag; PyPI has wheels only).Supported backends after this: 0.8.3–0.12.x and 0.14.x.
Local tests (
uv run --with pylibsparseir==X pytest tests/, Python 3.12, macOS arm64):The 0.8.3 failure is
test_boundary.py::test_c_library_failure_surfaces_as_exception, which expects theSPIR_NOT_SUPPORTED(-5) code that newer backends return. It already fails onmainlinewith 0.8.3; this PR does not touchsrc/ortests/.Closes #94.
🤖 Generated with Claude Code