Repository navigation
r202639: space-less circuits outside the grid - #24
Merged
Merged
Conversation
A panel that does not know its size reports 0, which the card took as the size and then refused to load. A size of 0, below zero, fractional or not a number is now treated as absent, and the size comes from the circuits. Part of the spanos3/r202639/03 batch 2 work.
Topology may report the panel's first and last breaker positions. The grid draws rows over that range, labelled with the positions' own numbers, instead of 1 to the panel size, so a breaker above the size is drawn and no empty slot appears below the first position. A panel that reports size 0 with its positions loads. Without reported positions the range is 1 to the size, as before, and it always widens to every occupied tab. Part of the spanos3/r202639/03 batch 2 work.
…e grid A topology row marked outside_panel is a meter with no breaker space and no relay. It is never a grid slot: it is drawn in a Meters strip above the grid with its name, its power in the import-positive sign with the direction it states (importing or exporting), and the energy it has imported and exported, with no toggle, rating or gear. An unknown reading shows "--" and states no direction. Such a meter is no load on the panel, so the Site stat's fallback sum leaves it out. In the list views it is never drawn or sorted as off, and it gets no on/off control. Part of the spanos3/r202639/03 batch 2 work.
The list's expanded chart drew a meter outside the panel as on, but the live update re-read its relay, which a meter does not have, and dimmed the chart as off. The update now reads the same on-state the list draws. Part of the spanos3/r202639/03 batch 2 work.
…el size A meter outside the panel occupies no breaker space, so a tab its row might name no longer widens the drawn position range or sets the size derived from the circuits. The predicate moves beside the layout helpers that now read it. Part of the spanos3/r202639/03 batch 2 work.
…strip The strip is hidden with the panel, as the grid is, and shows current in amps mode, as the grid does, with an unknown current as "--" and the direction still read from power. The card's size counts the strip when it is drawn. Part of the spanos3/r202639/03 batch 2 work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r202639: a topology row marked
outside_panelis a meter without a breaker space. It is drawn outside the grid.show_panel: false), as the grid is, and the card's size counts it when it is drawn.meters.title,meters.importing,meters.exporting,meters.imported,meters.exportedin every language.Known limitation. The
panel_topologycommand is admin-only, so a non-admin user's card discovers circuits from the entity registry instead. That path cannot tell a meter from a circuit, and it leaves meters out: they are not drawn, summed or placed in the grid. The meters remain Home Assistant entities.Stacked on #23.
dist/is not rebuilt here; the release rebuilds it.Checks
npm test: 616 passed in 58 files (592 in 57 before)npm run typecheck,npm run lint,node scripts/validate-i18n.mjs: cleannpm run build: clean