Repository navigation
r202639: link status of a circuit-fed battery - #204
Merged
Merged
Conversation
A battery whose feeding circuit names it in connection/feeds-device-id reports that circuit's feeds-device-status as connected, as an inverter or a charger already does, where no device claims it through a fed-by-* record. SpanBatterySnapshot.feed_circuit_id names the circuit. The circuit keeps device_type "circuit", and a battery ahead of the upstream lugs keeps reading its link from them. Part of the spanos3/r202639/03 batch 2 work.
cayossarian
changed the base branch from
feat/declared-unvalued-devices
to
prerelease/3.8
October 9, 2026 15:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r202639: a battery fed by a circuit reports its connection status.
connection/feeds-device-idnames the battery and no device claims it through afed-by-*record,SpanBatterySnapshot.connectedfollows that circuit'sfeeds-device-status, as for an inverter or a charger.Nonewhile the status is unpublished.SpanBatterySnapshot.feed_circuit_idnames the circuit;Nonewhere no circuit feeds the battery, and on the flat schema.device_type == "circuit"; a battery ahead of the upstream lugs keeps reading its link from them.Stacked on #200.
Checks:
pytest tests -q: 1548 passed, 7 skipped, 21 xfailed (13 new).pre-commit run --all-files: all hooks pass (ruff, black, mypy, pylint, bandit, vulture, coverage 96.53%).