Repository navigation
r202639: circuit feeds role - #205
Merged
Merged
Conversation
SpanCircuitSnapshot.feeds_role reports a circuit's connection/feeds-role as a FeedsRole, one of LOADS, SUBPANEL, SOLAR, STORAGE, GENERATOR, MIXED or UNUSED. It is None where the circuit declares no role, has not published it, or publishes a value outside that set. The role changes nothing else: device_type stays as published, and no inverter is made up for a circuit whose role is solar. FeedsRole and FEEDS_ROLES are exported. Part of the spanos3/r202639/03 batch 2 work.
The snapshot now reads a circuit's connection/feeds-role into feeds_role, so it is an addressed property and no longer a discovery row. The reference tree declares no role, so the discovery experiment proves the entry on a circuit given the declaration. Part of the spanos3/r202639/03 batch 2 work.
cayossarian
changed the base branch from
feat/panel-positions
to
prerelease/3.8
October 9, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r202639: each circuit reports its declared feeds role.
SpanCircuitSnapshot.feeds_role: FeedsRole | None, read fromconnection/feeds-role.Nonewhere the role is undeclared, unpublished, or outside the role set.FeedsRole(aLiteralof the seven roles) andFEEDS_ROLESare exported.connection/feeds-roleis now an addressed property, so it is no longer reported as a discovery row.device_typestays as published and no inverter is made up for a solar role. The two acceptance tests that expect a solar circuit to readpvstay registered as known divergences.Stacked on #201.
Checks:
pytest tests -q: 1578 passed, 7 skipped, 14 xfailed (28 new).pre-commit run --all-files: all hooks pass (ruff, black, mypy, pylint, bandit, vulture, coverage 96.54%).